feat(settings): implement admin delegation for SSO & SAML authentication#1053
Open
printminion-co wants to merge 2 commits intonextcloud:masterfrom
Open
feat(settings): implement admin delegation for SSO & SAML authentication#1053printminion-co wants to merge 2 commits intonextcloud:masterfrom
printminion-co wants to merge 2 commits intonextcloud:masterfrom
Conversation
Merged
6 tasks
printminion-co
force-pushed
the
mk/dev/admin-delegation-user_saml
branch
from
423eba0 to
53bf5f7
Compare
printminion-co
force-pushed
the
mk/dev/admin-delegation-user_saml
branch
4 times, most recently
from
fc21b71 to
7385ea1
Compare
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
- populate getAuthorizedAppConfig() with global oc_appconfig keys: type, general-require_provisioned_account, general-allow_multiple_user_back_ends, directLoginName - add #[AuthorizedAdminSetting(Admin::class)] to all SettingsController methods (reads + writes) so delegated admins can load and save settings Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
mk/dev/admin-delegation-user_saml
branch
from
7385ea1 to
58e2510
Compare
printminion-co
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IDelegatedSettingsin theAdminsettings class, addinggetName()andgetAuthorizedAppConfig()with the global config keysrequired for delegated access (
type,general-require_provisioned_account,general-allow_multiple_user_back_ends,directLoginName)#[AuthorizedAdminSetting(Admin::class)]to allSettingsControllerread and write methods so delegated admins can fully load and save settings
Why
IDelegatedSettingsallows Nextcloud admins to grant non-admin users accessto the SSO & SAML settings panel without giving them full admin rights.
Test plan
composer run test:unitcomposer run cs:fix(no changes expected)